-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): make cache TTL configurable #2798
Conversation
Signed-off-by: elchenberg <elchenberg@users.noreply.github.com>
Regarding the CLA: The CLA assistant asks me to sign a "SAP Individual Contributor License Agreement" (SAP as in the german software company). That does not seem right. Regarding the PR title: I am not sure what type of PR this is. A feature? A bugfix? A chore? Or something else? |
It is a feature. @elchenberg Oh, thanks for letting us know. It looks like something wrong. @itaysk Can you take a look?
|
@elchenberg Seems like a bug of cla-assistant. We'll look into it later, but I reverted it for now. Could you try that again? |
@krol3 Can you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @elchenberg , please only add in the readme this new parameter.
@@ -9,6 +9,7 @@ data: | |||
TRIVY_CACHE_DIR: "/home/scanner/.cache/trivy" | |||
{{- if .Values.trivy.cache.redis.enabled }} | |||
TRIVY_CACHE_BACKEND: {{ .Values.trivy.cache.redis.url | quote }} | |||
TRIVY_CACHE_TTL: {{ .Values.trivy.cache.redis.ttl | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the readme- parameters section
| trivy.cache.redis.ttl
| Specify redis ttl. e.g 3600s, 24h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I forgot about that!
Signed-off-by: elchenberg <elchenberg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@knqyf263 @elchenberg @krol3 its impossible to use these new things because chart versions are not bumped when you do changes to charts. Now the only way to use newest trivy helm chart things is to clone it locally and run. If you could https://github.com/aquasecurity/trivy/blob/main/helm/trivy/Chart.yaml#L4 increase this version, everyone could use these charts quite easily. |
also your ci pipelines is failing see: https://github.com/aquasecurity/trivy/actions/runs/3359974186/jobs/5568645331 it fails because the version is not increased. |
Description
Enables users to configure the cache TTL with a new helm value.
Related issues
Checklist
Signed-off-by: elchenberg elchenberg@users.noreply.github.com